Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readme.md: add nightly toolchain installation prereq #417

Closed
wants to merge 2 commits into from

Conversation

j2kun
Copy link
Contributor

@j2kun j2kun commented May 11, 2023

When trying to build concrete from source, I ran into the following error during make all. It seems it needs the nightly rust toolchain, which was not mentioned in the README. This PR adds the note.

AILED: tools/concretelang/concrete_cpu_rust-prefix/src/concrete_cpu_rust-stamp/concrete_cpu_rust-build /home/jkun/fhe/concrete/compilers/concrete-compiler/compiler/build/tools/concretelang/concrete_cpu_rust-prefix/
src/concrete_cpu_rust-stamp/concrete_cpu_rust-build
cd /home/jkun/fhe/concrete/backends/concrete-cpu/implementation && /usr/bin/cmake -P /home/jkun/fhe/concrete/compilers/concrete-compiler/compiler/build/tools/concretelang/concrete_cpu_rust-prefix/sr
c/concrete_cpu_rust-stamp/concrete_cpu_rust-build-Release.cmake
CMake Error at /home/jkun/fhe/concrete/compilers/concrete-compiler/compiler/build/tools/concretelang/concrete_cpu_rust-prefix/src/concrete_cpu_rust-stamp/concrete_cpu_rust-build-Release.cmake:37 (message):
  Command failed: 1

   'cargo' '+nightly' 'build' '--release' '--features=nightly'

See also                                                                                                                                                                                                                                                                                                                                                                                                                                                                          /home/jkun/fhe/concrete/compilers/concrete-compiler/compiler/build/tools/concretelang/concrete_cpu_rust-prefix/src/concrete_cpu_rust-stamp/concrete_cpu_rust-build-*.log                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                          -- stdout output is:
-- stderr output is:
error: toolchain 'nightly-x86_64-unknown-linux-gnu' is not installed

CMake Error at /home/jkun/fhe/concrete/compilers/concrete-compiler/compiler/build/tools/concretelang/concrete_cpu_rust-prefix/src/concrete_cpu_rust-stamp/concrete_cpu_rust-build-Release.cmake:47 (message):
  Stopping after outputting logs.


[379/3127] Performing build step for 'concrete_optimizer_rust'                                                                                                                                                                          ninja: build stopped: subcommand failed.                                                                                                                                                                                                make: *** [Makefile:145: concretecompiler] Error 1

@cla-bot
Copy link

cla-bot bot commented May 11, 2023

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @j2kun on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@j2kun
Copy link
Contributor Author

j2kun commented May 11, 2023

Signed the CLA. (bump?)

Copy link

cla-bot bot commented Dec 4, 2023

Thank you for your pull request. We require contributors to sign our Contributor License Agreement / Terms and Conditions, and we don't seem to have the users @j2kun on file. In order for us to review and merge your code, please sign:

  • For individual contribution: our CLA
  • for Bounty submission, if you are an individual: our T&C
  • for Bounty submission, if you are a company: our T&C
    to get yourself added.

If you already signed one of this document, just wait to be added to the bot config.

@j2kun
Copy link
Contributor Author

j2kun commented Dec 4, 2023

Re-signed

@bcm-at-zama
Copy link
Contributor

Ping @BourgerieQuentin: could we merge this before EOQ4?

@BourgerieQuentin
Copy link
Member

what's the issue with the cla bot? @aquint-zama

@j2kun
Copy link
Contributor Author

j2kun commented Jan 2, 2024

heh, it's not worth the fuss at this point for a doc update. Feel free to patch it and submit it via your normal means.

@j2kun j2kun closed this Jan 2, 2024
@aquint-zama
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jan 3, 2024
Copy link

cla-bot bot commented Jan 3, 2024

The cla-bot has been summoned, and re-checked this pull request!

@aquint-zama
Copy link
Contributor

@j2kun sorry it's a manual process on our end and I missed the notification, at least you did not signed the CLA (twice) for nothing, you are now added to the list of contributors

@aquint-zama
Copy link
Contributor

replaced by #662 to take care of commit message linting.... Thanks a lot @j2kun

@aquint-zama aquint-zama closed this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants