fix: rmv analytcis from the tests

ydataai · Jul 9, 2024 · a4afa34 · a4afa34
1 parent 488341c
commit a4afa34
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -1,6 +1,8 @@
 name: Multi-software test
 
-
+env:
+  YDATA_PROFILING_NO_ANALYTICS: False
+
 on:
   pull_request:
   push:
@@ -20,6 +22,7 @@ jobs:
         pandas: ["pandas>1.1"]
         numpy: ["numpy"]
         matplotlib: ["matplotlib<3.9"]
+        analytics: False
         include:
           - os: ubuntu-22.04
             python-version: 3.7.16
@@ -130,6 +133,7 @@ jobs:
         pip install --upgrade pip setuptools wheel
         pip install -r requirements.txt "${{ matrix.pandas }}" "${{ matrix.numpy }}"
         pip install -r requirements-test.txt
+        echo $YDATA_PROFILING_NO_ANALYTICS
     - run: make install
 
     - run: make test_cov
@@ -170,6 +174,7 @@ jobs:
       HADOOP_VERSION: ${{ matrix.hadoop }}
       SPARK_DIRECTORY: ${{ github.workspace }}/../
       SPARK_HOME: ${{ github.workspace }}/../spark/
+      YDATA_PROFILING_NO_ANALYTICS: ${{ matrix.analytics }}
     steps:
       - uses: actions/checkout@v4
       - name: Setup python

diff --git a/src/ydata_profiling/utils/logger.py b/src/ydata_profiling/utils/logger.py
@@ -17,7 +17,7 @@ def info_def_report(self, dataframe, timeseries: bool) -> None:  # noqa: ANN001
         if isinstance(dataframe, pd.DataFrame):
             dataframe = "pandas"
             report_type = "regular"
-        elif isinstance(dataframe, None):
+        elif dataframe is None:
             dataframe = "pandas"
             report_type = "compare"
         else: