[New] Support shorthand fragment syntax #1956
Conversation
| * @param {object} node - node to check. | ||
| * @returns {boolean} Whether or not the node if a JSX element or fragment. | ||
| */ | ||
| function isJSX(node) { |
There was a problem hiding this comment.
Suggestions for a better name welcome (isJSXElementOrFragment seemed too wordy)
| @@ -32,6 +32,10 @@ ruleTester.run('jsx-curly-brace-presence', rule, { | |||
| { | |||
| code: '<App {...props}>foo</App>' | |||
| }, | |||
| { | |||
| code: '<>foo</>', | |||
There was a problem hiding this comment.
This rule doesn't really care whether it's an element or a fragment, so I just added one simple valid test, and one invalid.
|
I'll wait to merge this til we've updated all the relevant rules. |
|
Quick q: I noticed some of the rules are using selectors e.g. /~https://github.com/yannickcr/eslint-plugin-react/blob/master/lib/rules/jsx-curly-brace-presence.js#L249 |
|
Fair point; altho nobody's complained. I guess we should fix that. |
|
I was asking mostly because this change could use the syntax for |
alexzherdev
changed the title
|
I believe I covered what needed to be covered, perhaps even redundantly. |
ghost
mentioned this pull request
Resolves #1694.