-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NativeAOT] Don't publish any *.o files that comes from NativeAOT. #18904
[NativeAOT] Don't publish any *.o files that comes from NativeAOT. #18904
Conversation
If anything we're supposed to link with *.o files, not publish them, but since we're currently not handling any *.o files, just explicitly remove them from the build. This avoids a warning where ComputeBundleLocation would issue a warning about not knowing what to do with them.
💻 [PR Build] Tests on macOS M1 - Mac Ventura (13.0) passed 💻✅ All tests on macOS M1 - Mac Ventura (13.0) passed. Pipeline on Agent |
💻 [PR Build] Tests on macOS M1 - Mac Big Sur (11.5) passed 💻✅ All tests on macOS M1 - Mac Big Sur (11.5) passed. Pipeline on Agent |
💻 [CI Build] Windows Integration Tests passed 💻✅ All Windows Integration Tests passed. Pipeline on Agent |
📚 [PR Build] Artifacts 📚Packages generatedView packagesPipeline on Agent |
This is worrying me. There are two .o files that should be in runtime pack, and we should link against one of them. I assume we do link against it because it does the runtime initialisation but it should be double checked. |
✅ API diff for current PR / commitLegacy Xamarin (No breaking changes)
NET (empty diffs)
✅ API diff vs stableLegacy Xamarin (No breaking changes).NET (No breaking changes)ℹ️ Generator diffGenerator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes) Pipeline on Agent |
This comment has been minimized.
This comment has been minimized.
🚀 [CI Build] Test results 🚀Test results✅ All tests passed on VSTS: simulator tests. 🎉 All 233 tests passed 🎉 Tests counts✅ bcl: All 69 tests passed. [attempt 2] Html Report (VSDrops) Download Pipeline on Agent |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Re:
This is worrying me. There are two .o files that should be in runtime pack, and we should link against one of them.
I assume we do link against it because it does the runtime initialisation but it should be double checked.
Yes, we are linking against: libbootstrapperdll.o
(2x checked)
Co-authored-by: Ivan Povazan <55002338+ivanpovazan@users.noreply.github.com>
If anything we're supposed to link with *.o files, not publish them, but since
we're currently not handling any *.o files, just explicitly remove them from
the build. This avoids a warning where ComputeBundleLocation would issue a
warning about not knowing what to do with them.
Contributes towards #18629.