Fix wolfmqtt-fuzzer: Null-dereference WRITE in MqttProps_Free

wolfSSL · Sep 21, 2021 · 84d4b53 · 84d4b53
1 parent 52653a6
commit 84d4b53
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/mqtt_client.c b/src/mqtt_client.c
@@ -906,8 +906,9 @@ static int MqttClient_WaitType(MqttClient *client, void *packet_obj,
             /* Determine if we received data for this request */
             if ((wait_type == MQTT_PACKET_TYPE_ANY ||
                  wait_type == packet_type ||
-                 MqttIsPubRespPacket(packet_type) == MqttIsPubRespPacket(wait_type)) &&
-               (wait_packet_id == 0 || wait_packet_id == packet_id))
+                 (MqttIsPubRespPacket(packet_type) &&
+                  MqttIsPubRespPacket(wait_type))) &&
+                (wait_packet_id == 0 || wait_packet_id == packet_id))
             {
                 use_packet_obj = packet_obj;
                 waitMatchFound = 1;