New way to require app #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also extra logging around the unlinking and renaming of the asar
But the AppPathFolder doesn't - even though it's a UNIX /, Windows normalises it to its own \
This is so ugly it hurts. You even see the DOS window, and the `> nul` redirect has no effect, so you see the "Press a key" prompt from the `timeout` command
This is to get around the fact that the prompt text from the timeout command was always being shown, even when redirecting to NUL The updater.exe is a really simple C# console app, compiled with [Mono](http://www.mono-project.com). ```` // updater.cs // // compile to updater.exe using: mcs updater.cs // // Takes two arguments; a source file and a destination file // Waits 5 seconds, then will move source to destination, as long as source exists using System; public class CommandLine { public static void Main(string[] args) { string updateAsar = ""; string appAsar = ""; // wait for the Electron app to close (5 secs) System.Threading.Thread.Sleep(5000); if (args.Length == 2) { updateAsar = args[0]; appAsar = args[1]; System.IO.FileInfo fileInfoSrc = new System.IO.FileInfo(updateAsar); System.IO.FileInfo fileInfoDest = new System.IO.FileInfo(appAsar); // the update asar doesn't exist if(!fileInfoSrc.Exists) Environment.Exit(1); if(fileInfoDest.Exists) { System.IO.File.Copy(updateAsar,appAsar, true); System.IO.File.Delete(updateAsar); } else { System.IO.File.Move(updateAsar,appAsar); } } // we need two filepaths - the update.asar and the app.asar else { Environment.Exit(1); } } } ````
|
@whitesmith Please merge this request :) |
|
@vanekj you can get updater.exe from here: jaygooby@7c56ea5 you'll need to install mono to compile it |
|
@AgentWS I am getting error while using electron-asar-updater as "core.require" is not a function. Any idea how to resolve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.