Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow pushes to ArrayCollection #67

Merged
merged 3 commits into from
Aug 28, 2020
Merged

Allow pushes to ArrayCollection #67

merged 3 commits into from
Aug 28, 2020

Conversation

weirdan
Copy link
Member

@weirdan weirdan commented Aug 28, 2020 •
edited
Loading

In recent doctrine/collections versions Collection extends ArrayAccess<null|TKey,TValue> and ArrayCollection narrows the $offset type to TKey (which shouldn't be allowed by LSP) for offsetGet(), offsetUnset() and offsetExists().

Ideally this should be fixed in Psalm by allowing null in addition to TKey for ArrayAccess::offsetSet(). Then all of the above wouldn't be necessary.

Fixes #66

weirdan added 3 commits August 28, 2020 04:45
@weirdan
Allow pushes to ArrayCollection
88af68f 
Surprisingly, this required to extend `ArrayAccess<null|TKey,TValue>` in
the parent interface, while it was fine with `ArrayAccess<TKey,TValue>`
when using the parent interface directly.

Fixes #56
@weirdan
Add ArrayCollection stub for doctrine/collections <1.6
861b223
@weirdan
CS fix
b1060bb
@weirdan weirdan merged commit d75579d into master Aug 28, 2020
@ondrejmirtes ondrejmirtes mentioned this pull request Apr 4, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NullArgument false-positive on ArrayCollection
1 participant
@weirdan