Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClassMetadataInfo::sequenceGeneratorDefinition #29

Merged

Conversation

zerkms
Copy link
Contributor

@zerkms zerkms commented Oct 16, 2019

Could you please merge this one as well.

The definition is taken from the official docblock:

    /**
     * READ-ONLY: The definition of the sequence generator of this class. Only used for the
     * SEQUENCE generation strategy.
     *
     * The definition has the following structure:
     * <code>
     * array(
     *     'sequenceName' => 'name',
     *     'allocationSize' => 20,
     *     'initialValue' => 1
     * )
     * </code>
     *
     * @var array
     *
     * @todo Merge with tableGeneratorDefinition into generic generatorDefinition
     */
    public $sequenceGeneratorDefinition;

PS: should also we mark things as @psalm-readonly?

@weirdan weirdan merged commit 9d09b29 into psalm:master Oct 17, 2019
@weirdan
Copy link
Member

weirdan commented Oct 17, 2019

Released in 0.8.0.

@weirdan
Copy link
Member

weirdan commented Oct 17, 2019

PS: should also we mark things as @psalm-readonly?

I'm not sure, as it may possibly trigger issues in Doctrine code (like ClassMetadataFactory that accesses it).

@zerkms zerkms deleted the class-metadata-info/sequence-generator-definition branch October 18, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants