Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: respect client.needHotEntry and client.needClientEntry #3178

Merged
merged 2 commits into from
Apr 13, 2021

Conversation

jkzing
Copy link
Contributor

@jkzing jkzing commented Apr 12, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Yes

Motivation / Use-Case

In version 4.0.0-beta.2 it still uses old option injectHot and injectClient to determine whether to inject dev server client, this PR corrects that by respecting new option client.needHotEntry and client.needClientEntry.

Breaking Changes

No

Additional Info

N/A

@alexander-akait
Copy link
Member

Need fix CI

@codecov
Copy link

codecov bot commented Apr 12, 2021

Codecov Report

Merging #3178 (5c6cd8f) into master (408530d) will increase coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3178      +/-   ##
==========================================
+ Coverage   94.93%   95.03%   +0.09%     
==========================================
  Files          38       38              
  Lines        1245     1249       +4     
  Branches      346      350       +4     
==========================================
+ Hits         1182     1187       +5     
+ Misses         57       56       -1     
  Partials        6        6              
Impacted Files Coverage Δ
lib/utils/DevServerPlugin.js 98.75% <100.00%> (+1.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 408530d...5c6cd8f. Read the comment docs.

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkzing
Copy link
Contributor Author

jkzing commented Apr 12, 2021

Humm, coverage decrease may be caused by newly added line breaks...

@alexander-akait alexander-akait merged commit a2b6db9 into webpack:master Apr 13, 2021
@alexander-akait
Copy link
Member

Thanks

@jkzing jkzing deleted the fix-client-entry branch April 16, 2021 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants