-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect client.needHotEntry and client.needClientEntry #3178
Conversation
Need fix CI |
1d46568
to
9764493
Compare
Codecov Report
@@ Coverage Diff @@
## master #3178 +/- ##
==========================================
+ Coverage 94.93% 95.03% +0.09%
==========================================
Files 38 38
Lines 1245 1249 +4
Branches 346 350 +4
==========================================
+ Hits 1182 1187 +5
+ Misses 57 56 -1
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Thanks |
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
In version
4.0.0-beta.2
it still uses old optioninjectHot
andinjectClient
to determine whether to inject dev server client, this PR corrects that by respecting new optionclient.needHotEntry
andclient.needClientEntry
.Breaking Changes
No
Additional Info
N/A