feat: add --client-overlay flag
#3148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3148 +/- ##
=======================================
Coverage 94.99% 94.99%
=======================================
Files 37 37
Lines 1218 1218
Branches 338 338
=======================================
Hits 1157 1157
Misses 55 55
Partials 6 6 Continue to review full report at Codecov.
|
anshumanv
previously approved these changes
Apr 4, 2021
anshumanv
reviewed
Apr 4, 2021
| ], | ||
| description: | ||
| 'Show a full-screen overlay in the browser when there are compiler errors or warnings.', | ||
| processor(opts) { |
There was a problem hiding this comment.
maybe we can have test to ensure processor behaviour in future
/cc @alexander-akait?
There was a problem hiding this comment.
Yep, e2e testing with playwright or puppeteer, let's do it in other PR
snitin315
force-pushed
the
feat/client-overlay
branch
from
639ec58 to
16e1e12
Compare
alexander-akait
approved these changes
Apr 5, 2021
anshumanv
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Add
--client-overlaycli option.Breaking Changes
None
Additional Info
No