This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 121
fix: try load official formatter #285
Merged
alexander-akait
merged 4 commits into
webpack-contrib:master
from
ricardogobbosouza:fix-resolve-formatter
Jul 4, 2019
Merged
fix: try load official formatter #285
alexander-akait
merged 4 commits into
webpack-contrib:master
from
ricardogobbosouza:fix-resolve-formatter
Jul 4, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardogobbosouza
requested review from
alexander-akait
and removed request for
alexander-akait
July 4, 2019 14:52
alexander-akait
suggested changes
Jul 4, 2019
alexander-akait
suggested changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, some notes about typo and test
alexander-akait
approved these changes
Jul 4, 2019
alexander-akait
suggested changes
Jul 4, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot about one
alexander-akait
approved these changes
Jul 4, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a:
Motivation / Use-Case
When using formatter as string try loading the official formatters