fix: align ignored module debug comment with webpack (#7736)

web-infra-dev · Aug 30, 2024 · bc3b36d · bc3b36d · rspack-bot · Aug 30, 2024
1 parent 0124d4c
commit bc3b36d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/crates/rspack_core/src/context_module_factory.rs b/crates/rspack_core/src/context_module_factory.rs
@@ -255,7 +255,7 @@ impl ContextModuleFactory {
         let raw_module = RawModule::new(
           "/* (ignored) */".to_owned(),
           module_identifier,
-          format!("{ident} (ignored)"),
+          format!("{specifier} (ignored)"),
           Default::default(),
         )
         .boxed();

diff --git a/crates/rspack_core/src/normal_module_factory.rs b/crates/rspack_core/src/normal_module_factory.rs
@@ -352,7 +352,7 @@ impl NormalModuleFactory {
             let raw_module = RawModule::new(
               "/* (ignored) */".to_owned(),
               module_identifier,
-              format!("{ident} (ignored)"),
+              format!("{resource} (ignored)"),
               Default::default(),
             )
             .boxed();
@@ -791,7 +791,10 @@ impl NormalModuleFactory {
         let raw_module = RawModule::new(
           "/* (ignored) */".to_owned(),
           module_identifier,
-          format!("{ident} (ignored)"),
+          format!(
+            "{} (ignored)",
+            data.request().expect("normal module should have request")
+          ),
           Default::default(),
         )
         .boxed();
Name	Base (2024-08-30 ef89e77)	Current	Change
10000_development-mode + exec	2.23 s ± 32 ms	2.24 s ± 29 ms	+0.32 %
10000_development-mode_hmr + exec	690 ms ± 14 ms	697 ms ± 15 ms	+0.96 %
10000_production-mode + exec	2.84 s ± 33 ms	2.85 s ± 33 ms	+0.21 %
arco-pro_development-mode + exec	1.86 s ± 71 ms	1.85 s ± 64 ms	-0.83 %
arco-pro_development-mode_hmr + exec	435 ms ± 2.1 ms	435 ms ± 1.4 ms	+0.10 %
arco-pro_production-mode + exec	3.27 s ± 55 ms	3.29 s ± 70 ms	+0.58 %
arco-pro_production-mode_generate-package-json-webpack-plugin + exec	3.33 s ± 93 ms	3.34 s ± 85 ms	+0.17 %
threejs_development-mode_10x + exec	1.65 s ± 14 ms	1.65 s ± 13 ms	-0.02 %
threejs_development-mode_10x_hmr + exec	799 ms ± 9.2 ms	807 ms ± 7.9 ms	+1.03 %
threejs_production-mode_10x + exec	5.16 s ± 23 ms	5.17 s ± 21 ms	+0.29 %
suite	result
modernjs	✅ success
_selftest	✅ success
nx	❌ failure
rspress	✅ success
rslib	✅ success
rsbuild	✅ success
examples	✅ success