fix(scroll): fix scroll when dealing with <details>

wallpants · Oct 25, 2023 · 4c9d159 · 4c9d159
1 parent a81d94f
commit 4c9d159
Showing 1 changed file with 16 additions and 1 deletion.
diff --git a/app/src/web/markdown/scroll.ts b/app/src/web/markdown/scroll.ts
@@ -53,6 +53,11 @@ export function getScrollOffsets(
 
     for (let index = 0, len = elements.length; index < len; index++) {
         const element = elements[index]!;
+
+        if (!element.checkVisibility()) {
+            continue;
+        }
+
         const { elemStartLine, elemEndLine, offsetTop, scrollHeight } = getAttrs(
             markdownContainerElement,
             element,
@@ -74,7 +79,16 @@ export function getScrollOffsets(
             }
 
             while (currLine < elemStartLine) {
-                sourceLineOffsets[currLine++] = [acc, element];
+                sourceLineOffsets[currLine] = [acc, element];
+
+                if (!acc && sourceLineOffsets[currLine - 1]?.[0]) {
+                    // In some cases acc is 0 here
+                    // it happens inside of <details>, maybe there are other cases.
+                    // If there's a prev offset already, we copy the value over
+                    sourceLineOffsets[currLine]![0] = sourceLineOffsets[currLine - 1]![0];
+                }
+
+                currLine++;
                 acc += perLine;
             }
         }
@@ -95,6 +109,7 @@ export function getScrollOffsets(
         }
     }
 
+    console.log("sourceLineOffsets: ", sourceLineOffsets);
     return sourceLineOffsets;
 }