fix(tsc): TS4082 not reported for functional component

close #4569
vuejs · Jul 22, 2024 · bc8521e · bc8521e
1 parent c0ec60a
commit bc8521e
Show file tree

Hide file tree

Showing 6 changed files with 41 additions and 2 deletions.
diff --git a/packages/language-core/lib/codegen/script/index.ts b/packages/language-core/lib/codegen/script/index.ts
@@ -125,7 +125,19 @@ export function* generateScript(options: ScriptCodegenOptions): Generator<Code>
 		yield* generateDefineProp(options, options.sfc.scriptSetup);
 		yield* generateScriptSetup(options, ctx, options.sfc.scriptSetup, options.scriptSetupRanges);
 	}
-	yield endOfLine;
+
+	yield `;`;
+	if (options.sfc.scriptSetup) {
+		// #4569
+		yield [
+			'',
+			'scriptSetup',
+			options.sfc.scriptSetup.content.length,
+			codeFeatures.verification,
+		];
+	}
+	yield newLine;
+
 	if (options.globalTypes) {
 		yield generateGlobalTypes(options.vueCompilerOptions);
 	}

diff --git a/packages/language-core/lib/codegen/script/scriptSetup.ts b/packages/language-core/lib/codegen/script/scriptSetup.ts
@@ -29,6 +29,15 @@ export function* generateScriptSetup(
 
 	if (scriptSetup.generic) {
 		if (!options.scriptRanges?.exportDefault) {
+			if (options.sfc.scriptSetup) {
+				// #4569
+				yield [
+					'',
+					'scriptSetup',
+					options.sfc.scriptSetup.content.length,
+					codeFeatures.verification,
+				];
+			}
 			yield `export default `;
 		}
 		yield `(<`;

diff --git a/packages/tsc/tests/index.spec.ts b/packages/tsc/tests/index.spec.ts
@@ -9,6 +9,7 @@ const shouldErrorDirs = [
 	'should-error',
 	'should-error-2',
 	'should-error-3',
+	'should-error-#4569',
 ];
 
 function prettyPath(path: string, isRoot: boolean) {
@@ -52,7 +53,7 @@ function runVueTsc(cwd: string) {
 	return new Promise((resolve, reject) => {
 		const cp = fork(
 			binPath,
-			['--noEmit'],
+			[],
 			{
 				silent: true,
 				cwd

diff --git a/test-workspace/tsc/should-error-#4569/main.vue b/test-workspace/tsc/should-error-#4569/main.vue
@@ -0,0 +1,7 @@
+<script lang="ts" setup generic="TItem">
+interface Props {
+	item: any;
+}
+
+defineProps<Props>();
+</script>
diff --git a/test-workspace/tsc/should-error-#4569/tsconfig.json b/test-workspace/tsc/should-error-#4569/tsconfig.json
@@ -0,0 +1,9 @@
+{
+	"extends": "../../tsconfig.json",
+	"include": [ "**/*" ],
+	"compilerOptions": {
+		"noEmit": false,
+		"emitDeclarationOnly": true,
+		"declaration": true,
+	}
+}
diff --git a/test-workspace/tsconfig.json b/test-workspace/tsconfig.json
@@ -10,6 +10,7 @@
 		"noUnusedParameters": true,
 		"skipLibCheck": true,
 		"allowJs": true,
+		"noEmit": true,
 		"jsx": "preserve",
 		"baseUrl": ".",
 	},