We should remove charts from the DB if fetching the tarball fails

[prydonius]

From @arapulido on February 16, 2018 15:41

I have Kubeapps deployed in Minikube (running 1.8, RBAC disabled)
I successfully deployed the service catalog (rbac disabled) and I was trying to add the OSBA broker to give it a spin.

I added the chart repo for OSBA (https://kubernetescharts.blob.core.windows.net/azure) and clicked on refreshed to get the charts.

The chart appears in the list of charts, but when I select it, the README file is not loaded, and the values file also show a 404.

Reason is that the tarball doesn't exist. We should remove those from the DB

Copied from original issue: vmware-archive/dashboard#89

[prydonius]

I did a helm fetch of this chart and there's no tarball for that chart. This is actually a bug in our chart syncing, since we dump metadata directly in the database we don't actually check if the tarball exists, but the readme and value fetching fails.

I think we can easily fix that by removing the chart from the db if fetching the tarball fails.

BTW, I think you were looking for the open-service-broker-azure chart, I'm guessing the Azure repo needs to be updated to remove that older chart (cc @ritazh @sozercan @arschles)

[prydonius]

From @arapulido on February 16, 2018 16:7

@prydonius thanks! I have updated the description to better reflect the actual issue

[prydonius]

#223 partially addresses this by adding a clear error message when the README is not there, however we still need to do something to indicate that the tarball could not be downloaded and the chart cannot be installed.

There are 2 possible solutions to this:

1. Have the chart sync record a field in the chart version document indicating the tarball failed to download

This could be exposed as hasTarball or tarballExists and if this is false or undefined we can disable the "Deploy" button and explain that the tarball might not be accessible.

2. Allow the chart version to be deployable, but have the Helm CRD controller report back that the tarball download failed.

This would be a longer term fix as it requires improvements to the Helm CRD controller, but something we may need to do anyway. The benefit of this is that the tarball not being available may be a temporary network issue, which may have recovered by the time of install.