Skip to content

Commit

Permalink
Fix create-private-registry test flakiness (#2059)
Browse files Browse the repository at this point in the history
* Wait for version selector

* Use cluster-admin role for kubeapps-operator in tests
  • Loading branch information
Andres Martinez Gotor authored Sep 24, 2020
1 parent fee5e81 commit 78a8c7f
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
13 changes: 9 additions & 4 deletions integration/use-cases/create-private-registry.js
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ test("Creates a private registry", async () => {
// Upgrade apache and verify.
await expect(page).toClick("cds-button", { text: "Upgrade" });

await new Promise((r) => setTimeout(r, 500));

let chartVersionElement = await expect(page).toMatchElement(
'select[name="chart-versions"]'
'.upgrade-form-version-selector select[name="chart-versions"]'
);
let chartVersionElementContent = await chartVersionElement.getProperty(
"value"
Expand All @@ -95,13 +97,16 @@ test("Creates a private registry", async () => {

// TODO(andresmgot): Avoid race condition for selecting the latest version
// but going back to the previous version
await new Promise((r) => setTimeout(r, 1000));
await new Promise((r) => setTimeout(r, 500));

await expect(page).toSelect('select[name="chart-versions"]', "7.3.16");
await expect(page).toSelect(
'.upgrade-form-version-selector select[name="chart-versions"]',
"7.3.16"
);

// Ensure that the new value is selected
chartVersionElement = await expect(page).toMatchElement(
'select[name="chart-versions"]'
'.upgrade-form-version-selector select[name="chart-versions"]'
);
chartVersionElementContent = await chartVersionElement.getProperty("value");
chartVersionValue = await chartVersionElementContent.jsonValue();
Expand Down
2 changes: 1 addition & 1 deletion script/e2e-test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ fi
kubectl cp ./use-cases "${pod}:/app/"
## Create admin user
kubectl create serviceaccount kubeapps-operator -n kubeapps
kubectl create clusterrolebinding kubeapps-operator-admin --clusterrole=admin --serviceaccount kubeapps:kubeapps-operator
kubectl create clusterrolebinding kubeapps-operator-admin --clusterrole=cluster-admin --serviceaccount kubeapps:kubeapps-operator
kubectl create clusterrolebinding kubeapps-repositories-write --clusterrole kubeapps:kubeapps:apprepositories-write --serviceaccount kubeapps:kubeapps-operator
## Create view user
kubectl create serviceaccount kubeapps-view -n kubeapps
Expand Down

0 comments on commit 78a8c7f

Please sign in to comment.