Skip to content

Commit

Permalink
Remove post-install annotation for apprepositories (#1754)
Browse files Browse the repository at this point in the history
We had added this to ensure that during installation of Kubeapps, the
creation of the app repository resources wouldn't trigger a sync job
to run before the upgrade job updates the schema. But one case we did
not anticipate is that if the installation is held up (network issues
or similar) and the helm install fails, the resources won't be present.

I think it's better to ensure they are always present so that the sync
job can eventually sync them (and update to safely migrate the schema
rather than recreating it - as per #1560).
  • Loading branch information
absoludity authored Jun 3, 2020
1 parent 3249a2c commit 60ec356
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions chart/kubeapps/templates/apprepositories.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,6 @@ apiVersion: kubeapps.com/v1alpha1
kind: AppRepository
metadata:
name: {{ .name }}
annotations:
"helm.sh/hook": post-install
"helm.sh/hook-weight": "10"
labels:
app: {{ template "kubeapps.apprepository.fullname" $ }}
chart: {{ template "kubeapps.chart" $ }}
Expand Down

0 comments on commit 60ec356

Please sign in to comment.