-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(datagrid): align action items focus/hover/selected with dropdown #1690
Conversation
Thank you, 🤖 Clarity Release Bot |
1eac31b
to
3280828
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should sync with design as there is no specification in Figma but I think we should have hover, :active, :focus, plus the additional states that we have on other components of this type if we count focus as selected ( selected-hover, selected-active ). Currently if you click on element with the mouse you are not getting to an :active state and it directly gets the focus / selected color and it get closed.
I see there is .active class there but not sure when this is activated.
3280828
to
e06b7c1
Compare
e06b7c1
to
209b93c
Compare
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Use the same styles as dropdown items for datagrid action items. This results in focus being indicated with an outline instead of focus and hover using the same background color.
CDE-2565