Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(combobox): null reference ngControl #1670

Merged
merged 3 commits into from
Jan 16, 2025

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Null reference errors can be seen in console when ngControl is not present.

Issue Number: N/A

What is the new behavior?

NO more null reference errors in console when ngControl is not present.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov self-assigned this Jan 15, 2025
@valentin-mladenov valentin-mladenov marked this pull request as ready for review January 15, 2025 09:24
Copy link
Contributor

github-actions bot commented Jan 15, 2025

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann
Copy link
Member

This should be combined with #1661 because it's the same bug.

Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, you already merged other half of this fix.

@valentin-mladenov valentin-mladenov merged commit dc10725 into main Jan 16, 2025
12 checks passed
@valentin-mladenov valentin-mladenov deleted the fix-null-reference-ng-control branch January 16, 2025 14:47
Copy link
Contributor

🎉 This PR is included in version 17.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants