Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(file-input): prevent validation error when accept is empty string #1668

Merged
merged 3 commits into from
Jan 15, 2025

Conversation

kevinbuhmann
Copy link
Member

PR Checklist

  • Tests for the changes have been added (for bug fixes / features)
  • [N/A] Docs have been added / updated (for bug fixes / features)
  • [N/A] If applicable, have a visual design approval

PR Type

Bugfix

What is the current behavior?

File accept error is set when accept="".

What is the new behavior?

File accept error is not set when accept="".

Does this PR introduce a breaking change?

No.

@kevinbuhmann kevinbuhmann requested a review from a team January 14, 2025 20:24
@kevinbuhmann kevinbuhmann self-assigned this Jan 14, 2025
@kevinbuhmann kevinbuhmann marked this pull request as ready for review January 14, 2025 20:24
Copy link
Contributor

github-actions bot commented Jan 14, 2025

👋 @kevinbuhmann,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@kevinbuhmann kevinbuhmann force-pushed the kevin/empty-file-accept branch from 6fe16bd to af705f8 Compare January 14, 2025 20:32
Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinbuhmann kevinbuhmann merged commit f60eead into main Jan 15, 2025
12 checks passed
@kevinbuhmann kevinbuhmann deleted the kevin/empty-file-accept branch January 15, 2025 15:34
Copy link
Contributor

🎉 This PR is included in version 17.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants