Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(breadcrumbs): new component #1637

Merged
merged 19 commits into from
Jan 7, 2025

Conversation

andyfeds
Copy link
Contributor

@andyfeds andyfeds commented Dec 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2324

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 @andyfeds,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@andyfeds andyfeds self-assigned this Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This PR introduces visual changes: dc3c1fa
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout poc/breadcrumbs
git fetch /~https://github.com/vmware-clarity/ng-clarity.git dc3c1fa31780bf0f34c8e4cc57df495c0e8f5a7c
git cherry-pick dc3c1fa31780bf0f34c8e4cc57df495c0e8f5a7c
git push

@andyfeds andyfeds changed the title Breadcrumbs component feat(breadcrumbs) : new component Dec 5, 2024
@kevinbuhmann kevinbuhmann changed the title feat(breadcrumbs) : new component feat(breadcrumbs): new component Dec 5, 2024
Copy link
Contributor

github-actions bot commented Dec 5, 2024

This PR introduces visual changes: e2567da
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout poc/breadcrumbs
git fetch /~https://github.com/vmware-clarity/ng-clarity.git e2567da1ef6abf91070e6e53f6927db6b9b5e7df
git cherry-pick e2567da1ef6abf91070e6e53f6927db6b9b5e7df
git push

@andyfeds andyfeds force-pushed the poc/breadcrumbs branch 2 times, most recently from 4dd2075 to a7dd25e Compare December 6, 2024 05:27
@andyfeds andyfeds marked this pull request as ready for review December 6, 2024 08:43
@andyfeds andyfeds requested a review from a team December 6, 2024 08:43
@andyfeds andyfeds marked this pull request as draft December 10, 2024 07:00
@andyfeds andyfeds force-pushed the poc/breadcrumbs branch 3 times, most recently from 4c47832 to 8b0d3df Compare December 16, 2024 03:41
@andyfeds andyfeds marked this pull request as ready for review December 16, 2024 13:47
Copy link
Contributor

This PR introduces visual changes: 5a0e71c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout poc/breadcrumbs
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 5a0e71c928d474647baff1f2c4c56631142375e0
git cherry-pick 5a0e71c928d474647baff1f2c4c56631142375e0
git push

Copy link
Contributor

This PR introduces visual changes: 2ae9a5c
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout poc/breadcrumbs
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 2ae9a5cf8c0abef6866504d55a1d43efd850a8d6
git cherry-pick 2ae9a5cf8c0abef6866504d55a1d43efd850a8d6
git push

Copy link
Contributor

This PR introduces visual changes: 8329d11
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout poc/breadcrumbs
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 8329d11e3e9f63fbc2c15e88d6e0e50dd9416d83
git cherry-pick 8329d11e3e9f63fbc2c15e88d6e0e50dd9416d83
git push

Copy link
Contributor

This PR introduces visual changes: 6b410f5
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout poc/breadcrumbs
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 6b410f59e90ea9015a11512951f14ae117a10b8b
git cherry-pick 6b410f59e90ea9015a11512951f14ae117a10b8b
git push

@andyfeds andyfeds merged commit 7812bc6 into vmware-clarity:main Jan 7, 2025
9 checks passed
dtsanevmw pushed a commit that referenced this pull request Jan 7, 2025
## PR Checklist

Please check if your PR fulfills the following requirements:

- [x] Tests for the changes have been added (for bug fixes / features)
- [x] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [ ] Bugfix
- [x] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: [CDE-2324](https://vmw-jira.broadcom.net/browse/CDE-2324)

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information

---------

Co-authored-by: Andrea Fernandes <andreaf1@vmware.com>
Co-authored-by: GitHub <noreply@github.com>
Copy link
Contributor

github-actions bot commented Jan 7, 2025

🎉 This PR is included in version 17.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants