Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(number-input): new component #1636

Merged
merged 6 commits into from
Jan 13, 2025
Merged

feat(number-input): new component #1636

merged 6 commits into from
Jan 13, 2025

Conversation

dtsanevmw
Copy link
Contributor

@dtsanevmw dtsanevmw commented Dec 5, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

New Number Input component.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2487

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Dec 5, 2024

👋 @dtsanevmw,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch 2 times, most recently from 7748808 to 13eac5e Compare December 11, 2024 23:38
@dtsanevmw dtsanevmw changed the title feat(number-picker): new component feat(number-input): new component Dec 11, 2024
Copy link
Contributor

This PR introduces visual changes: ba3d57d
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/number_picker
git fetch /~https://github.com/vmware-clarity/ng-clarity.git ba3d57df6b646612795afa1b5950bad6a33c2556
git cherry-pick ba3d57df6b646612795afa1b5950bad6a33c2556
git push

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch 5 times, most recently from 7764b70 to 4e0a5c7 Compare December 12, 2024 00:02
Copy link
Contributor

This PR introduces visual changes: 4936ae0
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/number_picker
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 4936ae0b5b03799701f53b873fba21282b365b23
git cherry-pick 4936ae0b5b03799701f53b873fba21282b365b23
git push

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch 2 times, most recently from 8b615f4 to 59e03ed Compare December 12, 2024 00:16
@dtsanevmw dtsanevmw self-assigned this Dec 12, 2024
@dtsanevmw dtsanevmw marked this pull request as ready for review December 12, 2024 00:17
@dtsanevmw dtsanevmw requested a review from a team December 12, 2024 00:18
Copy link
Contributor

This PR introduces visual changes: 93ab2cf
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/number_picker
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 93ab2cf35198d97b46314f8a069239f514c02356
git cherry-pick 93ab2cf35198d97b46314f8a069239f514c02356
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments.

@valentin-mladenov
Copy link
Contributor

valentin-mladenov commented Jan 7, 2025

Prefixes and suffixes #1644 for number input must be validated. You can do that in separate PR.

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch 3 times, most recently from 9813a5f to 63bb214 Compare January 9, 2025 11:01
Copy link
Contributor

github-actions bot commented Jan 9, 2025

This PR introduces visual changes: ff7a639
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/number_picker
git fetch /~https://github.com/vmware-clarity/ng-clarity.git ff7a639cb9a5592c2222d1d7364f047f4630ddd9
git cherry-pick ff7a639cb9a5592c2222d1d7364f047f4630ddd9
git push

Copy link
Contributor

@valentin-mladenov valentin-mladenov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comments.

Additiopnally create a separate chore PR for implementing the new nuimber-input component in the demo and in datagrid number filter.

Copy link
Member

@kevinbuhmann kevinbuhmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments. We cannot merge this as is because there are warnings for non-user elements (datagrid number filter).

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch from d3dc719 to 3a37e28 Compare January 10, 2025 15:41
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch from 3a37e28 to 4d374ee Compare January 10, 2025 15:54
Copy link
Contributor

This PR introduces visual changes: dc81a90
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout dtsanevmw/number_picker
git fetch /~https://github.com/vmware-clarity/ng-clarity.git dc81a902deb954be251fb9b62f84907b1737a291
git cherry-pick dc81a902deb954be251fb9b62f84907b1737a291
git push

@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch from 171ca3c to d9c1eda Compare January 13, 2025 09:09
@dtsanevmw dtsanevmw force-pushed the dtsanevmw/number_picker branch from d9c1eda to 8f1e866 Compare January 13, 2025 14:44
@dtsanevmw dtsanevmw merged commit 9311197 into main Jan 13, 2025
12 checks passed
@dtsanevmw dtsanevmw deleted the dtsanevmw/number_picker branch January 13, 2025 15:31
Copy link
Contributor

🎉 This PR is included in version 17.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Feb 8, 2025

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants