-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(number-input): new component #1636
Conversation
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
7748808
to
13eac5e
Compare
This PR introduces visual changes: ba3d57d
|
7764b70
to
4e0a5c7
Compare
This PR introduces visual changes: 4936ae0
|
8b615f4
to
59e03ed
Compare
This PR introduces visual changes: 93ab2cf
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments.
projects/angular/src/forms/number-input/number-input-container.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/number-input/number-input-container.ts
Outdated
Show resolved
Hide resolved
projects/angular/src/forms/number-input/number-input-container.ts
Outdated
Show resolved
Hide resolved
Prefixes and suffixes #1644 for number input must be validated. You can do that in separate PR. |
9813a5f
to
63bb214
Compare
This PR introduces visual changes: ff7a639
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check my comments.
Additiopnally create a separate chore PR for implementing the new nuimber-input component in the demo
and in datagrid number filter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comments. We cannot merge this as is because there are warnings for non-user elements (datagrid number filter).
d3dc719
to
3a37e28
Compare
projects/angular/src/forms/common/providers/control-class.service.ts
Outdated
Show resolved
Hide resolved
3a37e28
to
4d374ee
Compare
This PR introduces visual changes: dc81a90
|
171ca3c
to
d9c1eda
Compare
d9c1eda
to
8f1e866
Compare
🎉 This PR is included in version 17.6.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
New Number Input component.
What is the current behavior?
Issue Number: CDE-2487
What is the new behavior?
Does this PR introduce a breaking change?
Other information