fix(datagrid): hide only currently visible columns on detail open #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes vmware-clarity#1305 Signed-off-by: Martin Brom <martinbrom97@gmail.com>
|
👋 @dtsanevmw,
Thank you, 🤖 Clarity Release Bot |
dtsanevmw
changed the title
dtsanevmw
requested changes
Nov 28, 2024
dtsanevmw
reviewed
Nov 28, 2024
projects/angular/src/data/datagrid/render/main-renderer.spec.ts
Outdated
Show resolved
Hide resolved
dtsanevmw
reviewed
Nov 28, 2024
Signed-off-by: Martin Brom <martinbrom97@gmail.com>
dtsanevmw
approved these changes
Jan 9, 2025
dtsanevmw
added a commit
that referenced
this pull request
Jan 10, 2025
) ## PR Checklist Please check if your PR fulfills the following requirements: - [x] Tests for the changes have been added (for bug fixes / features) - [ ] Docs have been added / updated (for bug fixes / features) - [ ] If applicable, have a visual design approval ## PR Type What kind of change does this PR introduce? - [x] Bugfix - [ ] Feature - [ ] Code style update (formatting, local variables) - [ ] Refactoring (no functional changes, no api changes) - [ ] Build related changes - [ ] CI related changes - [ ] Documentation content changes - [ ] Other... Please describe: ## What is the current behavior? Issue Number: #1305 Because the first datagrid column is hidden, no column is shown when datagrid detail is open  ## What is the new behavior? The first visible column is shown when datagrid detail is open   ## Does this PR introduce a breaking change? - [ ] Yes - [x] No (not from API perspective, but yes, now we are showing a column and before the fix there was nothing shown) --------- Signed-off-by: Martin Brom <martinbrom97@gmail.com> Co-authored-by: Daniel Tsanev <127101685+dtsanevmw@users.noreply.github.com>
|
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #1305
Because the first datagrid column is hidden, no column is shown when datagrid detail is open
What is the new behavior?
The first visible column is shown when datagrid detail is open
Does this PR introduce a breaking change?