Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tokens): update alias overrides and remove unused #1603

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

valentin-mladenov
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • clarity.design website / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-2387

What is the new behavior?

Rename --cds-alias-object-vertical-navigation-background-color tokens to cds-alias-object-interaction-background-shade.
Remove unused overrride tokens:

  • --clr-nav-background-color
  • --cds-global-color-blue-25
  • --cds-alias-viz-severity-warning-light

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team October 25, 2024 10:50
@valentin-mladenov valentin-mladenov marked this pull request as ready for review October 25, 2024 10:50
Copy link
Contributor

github-actions bot commented Oct 25, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov
Copy link
Contributor Author

Follow up of vmware-clarity/core#337

@valentin-mladenov valentin-mladenov merged commit bed30e6 into main Oct 25, 2024
11 checks passed
@valentin-mladenov valentin-mladenov deleted the update-alias-tokens_cde-2387 branch October 25, 2024 14:29
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants