Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(badge): correct orange text color #1586

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

valentin-mladenov
Copy link
Contributor

@valentin-mladenov valentin-mladenov commented Oct 9, 2024

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Orange badge text is using --cds-global-color-black.

Issue Number: CDE-2322

What is the new behavior?

Orange badge text is using --cds-alias-typography-color-500.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@valentin-mladenov valentin-mladenov requested a review from a team October 9, 2024 10:41
@valentin-mladenov valentin-mladenov self-assigned this Oct 9, 2024
Copy link
Contributor

github-actions bot commented Oct 9, 2024

👋 @valentin-mladenov,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal Clarity Support space

Thank you,

🤖 Clarity Release Bot

@valentin-mladenov valentin-mladenov marked this pull request as ready for review October 9, 2024 10:43
Copy link
Contributor

github-actions bot commented Oct 9, 2024

This PR introduces visual changes: 246226b
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout correct-orange-badge-text-color_cde-2322
git fetch /~https://github.com/vmware-clarity/ng-clarity.git 246226b4db17c851a5d4aa761d71ce2d06ac97d7
git cherry-pick 246226b4db17c851a5d4aa761d71ce2d06ac97d7
git push

@valentin-mladenov valentin-mladenov merged commit c315c1e into main Oct 9, 2024
8 checks passed
@valentin-mladenov valentin-mladenov deleted the correct-orange-badge-text-color_cde-2322 branch October 9, 2024 11:07
Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants