-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(wizard): improve screen reader text for stepnav items #1558
Conversation
Thank you, 🤖 Clarity Release Bot |
67798b8
to
85ad332
Compare
0afa001
to
4f10c9a
Compare
- Add "Step" before step number. - Replace untranslated step status icon labels with translated text.
4f10c9a
to
1ebfb7e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-16.x 16.x
# Navigate to the new working tree
cd .worktrees/backport-16.x
# Create a new branch
git switch --create backport-1558-to-16.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 33bba6b8055cc6ee0562fa2e42e04549e27a2bcc
# Push it to GitHub
git push --set-upstream origin backport-1558-to-16.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-16.x Then, create a pull request where the |
Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary. |
PR Checklist
PR Type
Bugfix
What is the current behavior?
Issue Number: CDE-2292
What is the new behavior?
Does this PR introduce a breaking change?
The "Step" text will need to be translated. We don't count new common strings as breaking changes.