Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range): remove unnecessary thumb positioning for firefox (port of #1055) #1062

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Nov 16, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: CDE-1449

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

github-actions bot commented Nov 16, 2023

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@mivaylo mivaylo changed the title fix(range): fix misplaced range thumb on firefox fix(range): fix misplaced range thumb on firefox (port of #1055) Nov 16, 2023
@mivaylo
Copy link
Contributor Author

mivaylo commented Nov 16, 2023

This is a "backport" of #1055

@mivaylo
Copy link
Contributor Author

mivaylo commented Nov 16, 2023

This PR addresses this GitHub issue but for v15 #973

Copy link
Contributor

This PR introduces visual changes: ca9f0c9
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1449-fix-range-thumb-in-firefox-port-for-v15
git fetch /~https://github.com/vmware-clarity/ng-clarity.git ca9f0c972138778abee848c957c76028289a35b1
git cherry-pick ca9f0c972138778abee848c957c76028289a35b1
git push

@mivaylo mivaylo requested a review from a team November 16, 2023 16:29
@dtsanevmw dtsanevmw changed the title fix(range): fix misplaced range thumb on firefox (port of #1055) fix(range): remove unnecessary thumb positioning for firefox (port of #1055) Nov 16, 2023
@mivaylo mivaylo merged commit 002af03 into 15.x Nov 16, 2023
@mivaylo mivaylo deleted the cde-1449-fix-range-thumb-in-firefox-port-for-v15 branch November 16, 2023 16:33
Copy link
Contributor

🎉 This PR is included in version 15.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants