Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(range): remove unnecessary thumb positioning for firefox #1055

Merged
merged 2 commits into from
Nov 14, 2023

Conversation

mivaylo
Copy link
Contributor

@mivaylo mivaylo commented Nov 14, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • If applicable, have a visual design approval

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mivaylo mivaylo self-assigned this Nov 14, 2023
@mivaylo
Copy link
Contributor Author

mivaylo commented Nov 14, 2023

CDE-1449

Copy link
Contributor

github-actions bot commented Nov 14, 2023

👋 @mivaylo,

  • 🙏 The Clarity team thanks you for opening a pull request
  • 🎉 The build for this PR has succeeded
  • 🔍 The PR is now ready for review
  • 🍿 In the meantime, view a preview of this PR
  • 🖐 You can always follow up here. If you're a VMware employee, you can also reach us on our internal #clarity-support Slack channel

Thank you,

🤖 Clarity Release Bot

@dtsanevmw dtsanevmw changed the title fix(range): fix range thumb in firefox fix(range): remove unnecessary positioning for firefox Nov 14, 2023
@dtsanevmw dtsanevmw changed the title fix(range): remove unnecessary positioning for firefox fix(range): remove unnecessary thumb positioning for firefox Nov 14, 2023
Copy link
Contributor

This PR introduces visual changes: a93c4ed
If these changes are intended and correct, please cherry-pick the above commit to this PR.

git checkout cde-1449-fix-range-thumb-in-firefox
git fetch /~https://github.com/vmware-clarity/ng-clarity.git a93c4ed9e91c03b61adbac4a71d3f00b6fc85863
git cherry-pick a93c4ed9e91c03b61adbac4a71d3f00b6fc85863
git push

@mivaylo mivaylo force-pushed the cde-1449-fix-range-thumb-in-firefox branch from 890c36d to ba0967e Compare November 14, 2023 20:53
@mivaylo
Copy link
Contributor Author

mivaylo commented Nov 14, 2023

Addressing issue #973

@mivaylo mivaylo merged commit 88f3dcd into main Nov 14, 2023
@mivaylo mivaylo deleted the cde-1449-fix-range-thumb-in-firefox branch November 14, 2023 21:25
mivaylo added a commit that referenced this pull request Nov 16, 2023
…1055) (#1062)

## PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Tests for the changes have been added (for bug fixes / features)
- [ ] Docs have been added / updated (for bug fixes / features)
- [ ] If applicable, have a visual design approval

## PR Type

What kind of change does this PR introduce?

<!-- Please check the one that applies to this PR using "x". -->

- [x] Bugfix
- [ ] Feature
- [ ] Code style update (formatting, local variables)
- [ ] Refactoring (no functional changes, no api changes)
- [ ] Build related changes
- [ ] CI related changes
- [ ] Documentation content changes
- [ ] Other... Please describe:

## What is the current behavior?

<!-- Please describe the current behavior that you are modifying, or
link to a relevant issue. -->

Issue Number: CDE-1449

## What is the new behavior?

## Does this PR introduce a breaking change?

- [ ] Yes
- [x] No

<!-- If this PR contains a breaking change, please describe the impact
and migration path for existing applications below. -->

## Other information
Copy link
Contributor

🎉 This PR is included in version 16.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link
Contributor

Hi there 👋, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed PRs after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants