Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please do not push tags by default (--follow-tags) #123

Closed
ghostsquad opened this issue May 3, 2022 · 2 comments
Closed

Please do not push tags by default (--follow-tags) #123

ghostsquad opened this issue May 3, 2022 · 2 comments
Labels
enhancement

Comments

@ghostsquad
Copy link

--follow-tags should not be true by default, and configurable. I was just bitten by using gacp and having a local tag pushed that i didn't want upstream.
@ghostsquad
Copy link
Author

problematic line is here:
/~https://github.com/vivaxy/gacp/blob/master/src/gacp.ts#L89

@vivaxy
Copy link
Owner

vivaxy commented May 4, 2022

Thanks you for the suggestion.
Remove --follow-tags from default options may break the current behavior. It should be introduced with a major version.

@vivaxy vivaxy closed this as completed in f94879e May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghostsquad @vivaxy