New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved css a bit #2583

Closed

heff wants to merge 2 commits into videojs:master from heff:safe-css

Member

heff commented Sep 12, 2015

Added the Bootstrap, Foundation, and Reveal.js css files to my sandbox test, then fixed some bugs and added some rules where needed. I don't think this is a 100% test because the player isn't actually inside some of the framework components, but I think it's a pretty decent test.
Reduced the selector strength on some rules where it appeared to be safe.

heff added 2 commits

September 10, 2015 16:57


          Added CSS safety measures for when used in site frameworks

0a70353


          Reduced the selector strength for css rules where safe

c9a79d7

heff added this to the v5.0.0 milestone

heff closed this in

32aa9ed

heff mentioned this pull request

Do a pass on improving css selector strength and order #2509

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet