Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove listener used to test if passive listeners are supported #4787

Merged
merged 1 commit into from
Dec 4, 2017
Merged

Remove listener used to test if passive listeners are supported #4787

merged 1 commit into from
Dec 4, 2017

Conversation

Mulder90
Copy link
Contributor

@Mulder90 Mulder90 commented Dec 4, 2017

Once you have successfully tested that passive listeners are supported you should remove the test listeners :)

@Mulder90
Remove listener used to test if passive listeners are supported
c3b770c 
Once you have successfully tested that passive listeners are supported you should remove the test listeners :)
gkatsev
gkatsev approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

@gkatsev gkatsev added needs: LGTM Needs one or more additional approvals patch This PR can be added to a patch release. labels Dec 4, 2017
misteroneill
misteroneill approved these changes Dec 4, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, thanks.

@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Dec 4, 2017
@gkatsev gkatsev merged commit e582c3c into videojs:master Dec 4, 2017
@Mulder90 Mulder90 deleted the patch-1 branch December 5, 2017 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
confirmed patch This PR can be added to a patch release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mulder90 @misteroneill @gkatsev