Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persian translation #4741

Merged
merged 4 commits into from
Nov 16, 2017
Merged

Persian translation #4741

merged 4 commits into from
Nov 16, 2017

Conversation

EhsanCh
Copy link
Contributor

@EhsanCh EhsanCh commented Nov 12, 2017

Description

Optimize and complete translation

gkatsev
gkatsev approved these changes Nov 13, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@gkatsev
Copy link
Member

gkatsev commented Nov 13, 2017

Update of #4737, @mister-ben any other comments?

@gkatsev gkatsev added the needs: LGTM Needs one or more additional approvals label Nov 13, 2017
mister-ben
mister-ben approved these changes Nov 13, 2017
View reviewed changes
Copy link
Contributor

@mister-ben mister-ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@misteroneill misteroneill added confirmed and removed needs: LGTM Needs one or more additional approvals labels Nov 13, 2017
@gkatsev gkatsev merged commit 95d7832 into videojs:master Nov 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

@mister-ben mister-ben mister-ben approved these changes

Assignees
No one assigned
Labels
confirmed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@EhsanCh @gkatsev @mister-ben @misteroneill