Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm package too big for jsDelivr #4609

Closed
meritocrazy opened this issue Sep 12, 2017 · 7 comments
Closed

npm package too big for jsDelivr #4609

meritocrazy opened this issue Sep 12, 2017 · 7 comments

Comments

@meritocrazy
Copy link

I'm trying to load this package from jsDelivr CDN but it fails because the package is over 50 MB. Are there any files that could be removed to reduce the package size?

@MartinKolarik
Copy link

MartinKolarik commented Sep 12, 2017

50 MB out of the total 57 MB is the documentation under docs/ which should probably be excluded from npm anyway.

@thijstriemstra
Copy link
Contributor

thijstriemstra commented Sep 21, 2017

50 MB out of the total 57 MB is the documentation

+1 for cutting docs out of npm package.

@gkatsev
Copy link
Member

gkatsev commented Oct 6, 2017

I think it's good to have the documentation with the release and I think it's weird that jsdelivr makes such an exception when other CDNs have no issues (cdnjs, unpkg.com). But I get where you're coming from.
Currently, we rely on the docs folder in the release to deploy our docs site but we'll consider removing it when we change how the docs site is deployed.

@MartinKolarik
Copy link

@gkatsev the limit is there because when serving a file from a package for the first time, we need to download and unzip the full package. The bigger it is, the higher the chance it will take too long and user's request will fail, which is why we used this limit (in most cases, even a 150 MB package would download fast enough, but "most cases" is not good enough).

I understand why you would want the documentation in a release that people download manually, e.g. from GitHub, but npm is mostly used for automated installation and IMHO should only have the necessary code.

@gkatsev
Copy link
Member

gkatsev commented Dec 1, 2017

Btw, this should be fixed by #4774.

@MartinKolarik
Copy link

@gkatsev 👍 I forgot to mention it here but I added an exception for this package so it already works, but removing the docs is still a good idea.

@gkatsev
Copy link
Member

gkatsev commented Dec 1, 2017

Well, in that case, NEVERMIND! ;)
yeah, it'll also be good for the docs to auto-update, since we're now 3 semver-minor versions behind :)

@gkatsev gkatsev closed this as completed in 4dd000c Dec 4, 2017
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants