fix: TextTrackButton on Safari and iOS #4350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Safari and iOS, we use native text tracks, so, during text track button creation, textTracks() is populated. However, `this.kinds_` isn't necessarily set and ends up throwing. Instead, we want to move the fallback for `this.kinds_` from the constructor and right above the usage of `this.kinds_`.
misteroneill
approved these changes
May 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Safari and iOS, we use native text tracks, so, during text track
button creation, textTracks() is populated. However,
this.kinds_isn'tnecessarily set and ends up throwing.
Instead, we want to move the fallback for
this.kinds_from theconstructor and right above the usage of
this.kinds_.