Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Use a React component as a VJS component #4287

Merged
merged 1 commit into from
May 11, 2017
Merged

Docs: Use a React component as a VJS component #4287

merged 1 commit into from
May 11, 2017

Conversation

davekiss
Copy link
Contributor

Description

This section demonstrates how to register a VJS component, but allow it to be render within the React ecosystem.

Specific Changes proposed

Update docs.

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
  • Reviewed by Two Core Contributors

misteroneill
misteroneill approved these changes Apr 26, 2017
View reviewed changes
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, this seems really useful. Thanks @davekiss 👍

gkatsev
gkatsev approved these changes May 8, 2017
View reviewed changes
Copy link
Member

@gkatsev gkatsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @davekiss!

@gkatsev gkatsev merged commit cff2e50 into videojs:master May 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misteroneill misteroneill misteroneill approved these changes

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davekiss @misteroneill @gkatsev