Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make techCall_ sync again #3988

Merged
merged 1 commit into from
Jan 27, 2017
Merged

make techCall_ sync again #3988

merged 1 commit into from
Jan 27, 2017

Conversation

brandonocasey
Copy link
Contributor

Description

techCall_ used to be synchronous and is now async. This causes weird behavior for scenarios like this:

  1. player.muted(true);
  2. player.muted() === true // this will fail sometimes as setting muted is async

Specific Changes proposed

Make techCall_ async again

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chome, Firefox, IE)
  • Reviewed by Two Core Contributors

@brandonocasey brandonocasey merged commit 3585af0 into master Jan 27, 2017
@brandonocasey brandonocasey deleted the fix/sync-tech-call branch January 27, 2017 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gkatsev gkatsev gkatsev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brandonocasey @gkatsev