Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sass): upgrade to latest version of grunt-sass #3897

Merged
merged 1 commit into from
Jan 3, 2017

Conversation

gkatsev
Copy link
Member

@gkatsev gkatsev commented Dec 29, 2016

I think the reason why we couldn't update sass in videojs no longer applies. Since we can update sass without a hassle, I think that's the best route right now instead of taking it out.

@gkatsev gkatsev added minor This PR can be added to a minor release. It should not be added to a patch release. confirmed labels Dec 30, 2016
Copy link
Member

@misteroneill misteroneill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will come back to haunt us. Mark my words! 😜

@gkatsev gkatsev merged commit 83d453b into videojs:master Jan 3, 2017
@gkatsev gkatsev deleted the update-sass branch January 3, 2017 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
confirmed minor This PR can be added to a minor release. It should not be added to a patch release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants