fix: off text tracks should be set based on current state (#4775)

videojs · Dec 4, 2017 · 904989d · 904989d
1 parent 4dd000c
commit 904989d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/js/control-bar/text-track-controls/off-text-track-menu-item.js b/src/js/control-bar/text-track-controls/off-text-track-menu-item.js
@@ -45,7 +45,6 @@ class OffTextTrackMenuItem extends TextTrackMenuItem {
     options.selectable = true;
 
     super(player, options);
-    this.selected(true);
   }
 
   /**

diff --git a/src/js/control-bar/text-track-controls/text-track-menu-item.js b/src/js/control-bar/text-track-controls/text-track-menu-item.js
@@ -76,6 +76,9 @@ class TextTrackMenuItem extends MenuItem {
         tracks.dispatchEvent(event);
       });
     }
+
+    // set the default state based on current tracks
+    this.handleTracksChange();
   }
 
   /**
-Original file line number
+Diff line change
@@ Expand Up / @@ -45,7 +45,6 @@ class OffTextTrackMenuItem extends TextTrackMenuItem { @@
         options.selectable = true;
         super(player, options);
-        this.selected(true);
       }
       /**
@@ Expand Down @@