disable default features for turbopack-ecmascript-plugins (#5363)

### Description it breaks no-plugin in next.js
vercel · Jun 22, 2023 · 08aba99 · 08aba99
1 parent c0b4514
commit 08aba99
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -115,7 +115,7 @@ turbopack-css = { path = "crates/turbopack-css" }
 turbopack-dev = { path = "crates/turbopack-dev" }
 turbopack-dev-server = { path = "crates/turbopack-dev-server" }
 turbopack-ecmascript = { path = "crates/turbopack-ecmascript" }
-turbopack-ecmascript-plugins = { path = "crates/turbopack-ecmascript-plugins" }
+turbopack-ecmascript-plugins = { path = "crates/turbopack-ecmascript-plugins", default-features = false }
 turbopack-ecmascript-runtime = { path = "crates/turbopack-ecmascript-runtime" }
 turbopack-env = { path = "crates/turbopack-env" }
 turbopack-image = { path = "crates/turbopack-image" }

diff --git a/crates/turbopack-binding/Cargo.toml b/crates/turbopack-binding/Cargo.toml
@@ -209,7 +209,7 @@ turbopack-css = { optional = true, workspace = true }
 turbopack-dev = { optional = true, workspace = true }
 turbopack-dev-server = { optional = true, workspace = true }
 turbopack-ecmascript = { optional = true, workspace = true }
-turbopack-ecmascript-plugins = { optional = true, workspace = true }
+turbopack-ecmascript-plugins = { optional = true, workspace = true, default-features = false }
 turbopack-ecmascript-runtime = { optional = true, workspace = true }
 turbopack-env = { optional = true, workspace = true }
 turbopack-image = { optional = true, workspace = true }

diff --git a/crates/turbopack-ecmascript-plugins/src/transform/swc_ecma_transform_plugins.rs b/crates/turbopack-ecmascript-plugins/src/transform/swc_ecma_transform_plugins.rs
@@ -45,6 +45,8 @@ impl SwcPluginModule {
 
         #[cfg(not(feature = "swc_ecma_transform_plugin"))]
         {
+            let _ = plugin_name;
+            let _ = plugin_bytes;
             Self(())
         }
     }
@@ -105,6 +107,7 @@ impl SwcEcmaTransformPluginsTransformer {
     // [TODO] Due to WEB-1102 putting this module itself behind compile time feature
     // doesn't work. Instead allow to instantiate dummy instance.
     #[cfg(not(feature = "swc_ecma_transform_plugin"))]
+    #[allow(clippy::new_without_default)]
     pub fn new() -> Self {
         Self {}
     }