Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors on Resident Evil 2 and Testing on Other Games #155

Closed
vsylva opened this issue Feb 14, 2024 · 7 comments · Fixed by #158
Closed

Errors on Resident Evil 2 and Testing on Other Games #155

vsylva opened this issue Feb 14, 2024 · 7 comments · Fixed by #158

Comments

@vsylva
Copy link
Contributor

vsylva commented Feb 14, 2024

{7BEBC450-7DF1-4a5c-9C75-36ADAF8AF010}

/~https://github.com/veeenu/hudhook/blob/heck-dcomp/examples/simple_hook.rs

Injecting "simple_hook.dll" after the game's logo appears will result in the aforementioned error.
Injecting it after the game's main menu appears allows it to run properly.

OGL game Rune Factory 4, DX11 game Sekiro, DX12 game Resident Evil 3 perform well.

@veeenu
Copy link
Owner

veeenu commented Feb 15, 2024

That branch is in a broken state, dx9 and opengl aren't done ye because I can't find a way to share their buffer. I'm working on a Vulkan renderer atm which should be able to deal with that iiuc.

@vsylva
Copy link
Contributor Author

vsylva commented Feb 15, 2024

That branch is in a broken state, dx9 and opengl aren't done ye because I can't find a way to share their buffer. I'm working on a Vulkan renderer atm which should be able to deal with that iiuc.

(☆▽☆)👍

@veeenu veeenu mentioned this issue Feb 24, 2024
4 tasks
@vsylva
Copy link
Contributor Author

vsylva commented Feb 24, 2024

Sekiro (DX11) passed the test.
image

Resident Evil 2 (DX12) and Resident Evil 3 (DX12) failed the test; once demo_hook_dx12.dll is injected, it will crash immediately.
image

Rune Factory 4 (OGL3) cannot pass, error: ERROR ThreadId(02) hudhook::hooks::opengl3: src\hooks\opengl3.rs:92: Render error: Error { code: HRESULT(0x80070057), message: "Invalid parameter." }
image

@veeenu
Copy link
Owner

veeenu commented Feb 24, 2024

Thank you for testing these! I should probably add some observability, I'm not sure why those errors happen.

@vsylva
Copy link
Contributor Author

vsylva commented Feb 28, 2024

Thank you for testing these! I should probably add some observability, I'm not sure why those errors happen.

7bbbe06

(DX12) Resident Evil 2 and Resident Evil 3 appear to work well

image
image

(DX11) Sekiro as well

image

@veeenu
Copy link
Owner

veeenu commented Feb 28, 2024

Absolutely insane. Thank you for testing those @vsylva

I have the OpenGL renderer left to do and then we can wrap this up and release 0.6.

@vsylva
Copy link
Contributor Author

vsylva commented Feb 28, 2024

Owner

GOOOOOOOOOOOOOOOOODDDDD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants