Add ability to delete an alias from room directory #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hidden behind shift-click for now, but we're going to need to do this a lot to moderate the public room list.
Also clean up RoomDirectory a bit and just pass the room object around rather than the name / alias, so now we don't have to look up the room by ID again.
| var QuestionDialog = sdk.getComponent("dialogs.QuestionDialog"); | ||
| var ErrorDialog = sdk.getComponent("dialogs.ErrorDialog"); | ||
|
|
||
| var room_alias = get_display_alias_for_room(room); |
There was a problem hiding this comment.
we already have alias - this appears redundant.
dbkr
added a commit
that referenced
this pull request
Jun 23, 2016
Fixes regression introduced by #1680
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hidden behind shift-click: ultimately this should be expanded upon to be able to delete any of the aliases rather than just the default, but this is a start that will let us do some moderation without doing it manually with cURL.
Also tidies up RoomDirectory a bit by passing the room objects around so we don't have to look them up by in the data structure later.