Fix RoomDirectory to join by alias whenever possible. #1615
Conversation
|
wait, there's a better way to do this |
This still doesn't actually cause the room to be joined by alias though, so still need to fix that
|
ok, all yours |
|
ugh. everything is awful. but ok. Are you sure this fixes #1532? I don't think the RoomDirectory component is involved in that. |
|
Not merging this right now because I don't want to babysit its deployment to /develop |
|
Ah, I made this less awful... and then somehow managed to not actually push the commit. Now requires matrix-org/matrix-react-sdk#304 which fixes #1532. ptal :) |
| }; | ||
| if (roomAlias) { | ||
| payload.action = 'view_room_alias'; | ||
| payload.room_alias = roomAlias; |
There was a problem hiding this comment.
Is it a mistake to throw away the room id if we know it? I'm worried about cases where the directory somehow gets out of sync with the room_aliases in the rooms, so you actually end up joining a different room to the one you chose in the directory.
Perhaps at least a comment to this effect?
There was a problem hiding this comment.
Actually, shouldn't this logic of 'prefer the alias if we have it' be in MatrixChat?
|
Certainly an improvement. Looks good modulo my comment. |
|
ptal |
|
lgtm |
This doesn't really attempt to unravel the different code paths that joining a room can take (apart from commenting it a little). It just fixes this bug for now.