Do not fail on server liveliness checks during startup #9960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also warn about deprecated config option usage. See #9828
dbkr
approved these changes
Jun 6, 2019
| console.warn( | ||
| "DEPRECATED CONFIG OPTION: In the future, default_hs_url will not be accepted. Please use " + | ||
| "default_server_config instead.", | ||
| ); |
There was a problem hiding this comment.
I would be OK with keeping this as a shorthand, but fine either way.
There was a problem hiding this comment.
I'm of similar thinking, although also wanting to keep the ways of configuring a homeserver to a minimum. I've hopefully worded the docs to say "it's deprecated, but less deprecated than default_*_url"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also warn about deprecated config option usage.
See matrix-org/matrix-react-sdk#3067