-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Start documenting keyboard shortcuts #7165
Conversation
docs/shortcuts.md
Outdated
@@ -0,0 +1,9 @@ | |||
# Keyboard Shortcuts | |||
|
|||
- <kbd>Ctrl</kbd>+<kbd>m</kbd> - toggle markdown |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are actually Control or Command depending on whether you're not on a Mac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all of them or just this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better?
Looks good to me |
Thanks for making this contribution a while back. It looks like this one fell through the cracks a bit. I have added it to the review queue, so hopefully we'll get a fresh look at it soon. |
@jryans no worries, I get it that you have a huge load of issues and PRs |
I think it would be fine to land this as-is. We can always update or extend it later. @ptman Please update the PR or each commit with your sign off as described in CONTRIBUTING.rst. We should be able to merge this once that's done. |
I'm sure I don't know all of them. Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
Signed-off-by: Paul Tötterman <paul.totterman@iki.fi>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! 😁 I am sure there are more to list, but we can always add those at any time.
I am assuming the test failures in CI are unrelated since there are no code changes here. |
Yes, I certainly hope there are more, but those were the only ones I could find when I wrote this. Would especially like a shortcut to switch to the next unread room. |
I'm sure I don't know all of them.