Test 'return-to-app' functionality #4352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test for the 'log in as user' functionality, as well as the 'return to app' functionality.
|
(This is failing because matrix-org/matrix-react-sdk#1116 hasn't landed yet) |
lukebarnard1
approved these changes
Jun 19, 2017
| // we simulate a click on the 'login' button by firing off | ||
| // the relevant dispatch. | ||
| // | ||
| // XXX: is it an anti-pattern to access the react-sdk's |
There was a problem hiding this comment.
We don't really need to test the login button before every test, I think it'd be best to use start_login given that this is the beforeEach. If we had a dedicated integration test for the flow where the user clicks on "Login", logs in etc., then it'd be better to find the button and simulate a click.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test for the 'log in as user' functionality, as well as the 'return to
app' functionality.