onLoadCompleted is now onTokenLoginCompleted #4335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test/app-tests/loading.js
Outdated
| @@ -47,7 +47,7 @@ describe('loading:', function () { | |||
| // the mounted MatrixChat | |||
| let matrixChat; | |||
|
|
|||
| // a promise which resolves when the MatrixChat calls onLoadCompleted | |||
| // a promise which resolves when the MatrixChat calls onTokenLoginCompleted | |||
There was a problem hiding this comment.
But it only calls onTokenLoginCompleted if the token login was a success. Should this test not just fail? Unless it logins in with a token explicitly?
There was a problem hiding this comment.
Ah only the token login test uses this promise. Could you rename the promise in that case? 😇
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codep of matrix-org/matrix-react-sdk#1110