Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show redact in context menu only if has PL to/sent message #3925

Merged
merged 6 commits into from
May 30, 2017
Merged

show redact in context menu only if has PL to/sent message #3925

merged 6 commits into from
May 30, 2017

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 16, 2017

t3chguy added 4 commits May 16, 2017 13:15
@t3chguy
first go at show redact only if we can redact
aff1e14 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
use new RoomState method from matrix-org/matrix-js-sdk/pull/435
d55f4f9 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
remove no longer required parseIntWithDefault
db78534 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
move mxEvent.status check to js-sdk
58ada2c 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@lukebarnard1
Copy link
Contributor

This may indeed work but I'm wary of inspecting js-sdk state in render. In theory we should only ever query state or props. In this case we should consider whether the result of maySendRedactionForEvent will change whilst this component is visible. I could imagine that it would change if the user's power levels change.

t3chguy added 2 commits May 29, 2017 23:17
@t3chguy
Merge branch 'develop' of github.com:vector-im/riot-web into t3chguy/…
d3f9304 
…show_redact_if_can
@t3chguy
check PL on change as well as on comp load, that way it'll show remov…
17c4e7a 
…e button if PL increases later.

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy
Copy link
Member Author

t3chguy commented May 29, 2017

@lukebarnard1 how about now, it'll re-check on a PL change

@lukebarnard1 lukebarnard1 merged commit 543f4ef into develop May 30, 2017
This was referenced May 30, 2017
Merged
Closed
@t3chguy t3chguy deleted the t3chguy/show_redact_if_can branch October 29, 2017 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukebarnard1 lukebarnard1 lukebarnard1 approved these changes

Assignees

@lukebarnard1 lukebarnard1

Labels
X-Release-Blocker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@t3chguy @lukebarnard1 @ara4n