Height:100% for welcome pages on Safari #3340
Conversation
|
This sounds like a worryingly invasive change, in terms of changing the |
| @@ -100,6 +100,11 @@ limitations under the License. | |||
| * flex itself. | |||
There was a problem hiding this comment.
Right, I even commented this: "Height has to be auto here for RoomView to correctly fit when the Toolbar is shown". This is why it's not set to 100%. Unless the phase of the moon has changed since I wrote this, I'd expect it still to be true.
Luke: have you tested this with the MatrixToolbar visible across the top of the page (e.g. showing 'you're a guest' or 'new version' text)?
There was a problem hiding this comment.
I have now and as far as I can tell, it's fine. (Albeit I'm testing with Chrome)
There was a problem hiding this comment.
TODO: Test on Firefox and Safari
There was a problem hiding this comment.
Tests done for Chrome, Safari, Firefox on macOS - seems to work without upsetting anything
|
lgtm then. please fix the comment that says "height must be auto!!!!" before merging. |
Having tested Riot with the middlePanel having a height of 100%, it seems to be OK.
Fix for #3298
This seems to not have any side-effects.