Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modernizr check for subtle crypto as we require it all over the place #13828

Merged
merged 1 commit into from
Jun 2, 2020
Merged

Modernizr check for subtle crypto as we require it all over the place #13828

merged 1 commit into from
Jun 2, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented May 27, 2020

I ran into the issue with end-to-end tests getting stuck during SSSS setup in Login due to being in an insecure context without subtleCrypto

@t3chguy
Modernizr check for subtle crypto as we require it all over the place
57d2026 
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
@t3chguy t3chguy requested a review from a team May 27, 2020 23:32
jryans
jryans approved these changes Jun 2, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, sounds reasonable to me!

@t3chguy t3chguy merged commit d0679ef into develop Jun 2, 2020
@t3chguy t3chguy deleted the t3chguy/modernizr-subtleCrypto branch June 2, 2020 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@t3chguy @jryans