Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

index.html: Place noscript on top of the page #12563

Merged
merged 2 commits into from
Feb 28, 2020
Merged

index.html: Place noscript on top of the page #12563

merged 2 commits into from
Feb 28, 2020

Conversation

krkk
Copy link
Contributor

@krkk krkk commented Feb 28, 2020

Before this change, you had to scroll down to see the noscript element.
This change places the noscript element on top of the page making sure that a user will see this message when site is loaded without JavaScript.

Related: #178

Karol Kosek and others added 2 commits February 22, 2020 21:14
Before this change, you had to scroll down to see the noscript element.
This change places the noscript element on top of the page making sure
that a user will see this message when site is loaded without JavaScript.

Signed-off-by: Karol Kosek <krkk@krkk.ct8.pl>
@turt2live turt2live self-requested a review February 28, 2020 20:35
@turt2live turt2live added the Z-Community-PR Issue is solved by a community member's PR label Feb 28, 2020
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks fine, assuming the CI passes. I've merged in latest develop as it appears to have been based off an older develop branch, and the tests weren't happy about that.

@turt2live turt2live merged commit 0e37aa9 into element-hq:develop Feb 28, 2020
@krkk krkk deleted the noscript branch February 28, 2020 21:20
t3chguy pushed a commit that referenced this pull request Oct 17, 2024
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants